Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37645 )
Change subject: mushu: Create initial build ......................................................................
Patch Set 4:
(8 comments)
https://review.coreboot.org/c/coreboot/+/37645/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37645/4//COMMIT_MSG@7 PS4, Line 7: mushu: Create initial build mb/google/hatch: Add mushu variant
https://review.coreboot.org/c/coreboot/+/37645/4//COMMIT_MSG@11 PS4, Line 11: >> One `>` too much?
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/mushu/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/... PS4, Line 11: [PchSerialIoIndexSPI1] = PchSerialIoPci, This is off later in the devtree.
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/... PS4, Line 26: RFU The meaning of "RFU" isn't obvious. I'd rather use the full "Reserved for future use" phrase.
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/... PS4, Line 27: PS175 What is this? I would rather specify the function of this device (touchscreen, touchpad, scaler...) here.
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/... PS4, Line 28: MST Is this MStar? If so, why does the devtree say Realtek RTD2142 later?
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/... PS4, Line 36: i2c[0] This is disabled, so I guess this could be dropped
https://review.coreboot.org/c/coreboot/+/37645/4/src/mainboard/google/hatch/... PS4, Line 41: .i2c[1] Did you mean `.i2c[2]` ?