Ivy Jian has posted comments on this change. ( https://review.coreboot.org/29656 )
Change subject: mb/google/kahlee/variants/delan: Enable Weida touchscreen device
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29656/1/src/mainboard/google/kahlee/variants...
File src/mainboard/google/kahlee/variants/delan/devicetree.cb:
https://review.coreboot.org/#/c/29656/1/src/mainboard/google/kahlee/variants...
PS1, Line 179: 130
this looks pretty long compared to the other touchscreens?
That is required from vendor and described in datasheet.
refer to : issue https://issuetracker.google.com/issues/111102092#comment8
--
To view, visit
https://review.coreboot.org/29656
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1484a482de6282c97f3aac329f217bbcb7dbd18
Gerrit-Change-Number: 29656
Gerrit-PatchSet: 1
Gerrit-Owner: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Kurtz
djkurtz@google.com
Gerrit-Comment-Date: Sat, 17 Nov 2018 02:08:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No