Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45333 )
Change subject: soc/amd/picasso: Add Upd for support force USB3 to Gen1 by port ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45333/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45333/1//COMMIT_MSG@7 PS1, Line 7: soc/amd/picasso: Add Upd for support force USB3 to Gen1 by port Maybe:
Add UPD to force USB3 to Gen1 by port
https://review.coreboot.org/c/coreboot/+/45333/1//COMMIT_MSG@9 PS1, Line 9: add upd usb3_port_force_gen1 for support USB3 port to gen1 Please start sentences with a capital letter and finish with a dot/period.
https://review.coreboot.org/c/coreboot/+/45333/1//COMMIT_MSG@13 PS1, Line 13: TEST=Build,verify the USB3 speed in gen1 Please add a space after the comma.
https://review.coreboot.org/c/coreboot/+/45333/1/src/soc/amd/picasso/chip.h File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/45333/1/src/soc/amd/picasso/chip.h@... PS1, Line 171: uint32_t usb3_port_force_gen1; Keep the blank line before the comment?