Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38542 )
Change subject: sc7180: QSIP SPI NOR addressing mode ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38542/1/src/drivers/spi/spi_flash.c File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/c/coreboot/+/38542/1/src/drivers/spi/spi_flash.c... PS1, Line 497: 0x15 Why are we issuing commands to devices that may not apply? This does not seem appropriate since you don't know what type of device is actually there. These commands are device specific. Likewise, this seems like a workaround for the part being potentially in a 4 byte addressing mode. However, I don't think this check belongs in the main part of the code here as well as being done unconditionally.