Attention is currently required from: Cliff Huang, Felix Singer, Lance Zhao, Tim Wawrzynczak, minyu li.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80781?usp=email )
Change subject: src/acpi: Modify ACPI revision ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80781/comment/001b8932_79ce01c8 : PS1, Line 2: E-wells li.minyu@h3c.com Please replace E-wells by your name.
git config --global user.name "Your name" git commit --author="Your name li.minyu@h3c.com" --amend -s
https://review.coreboot.org/c/coreboot/+/80781/comment/48e27d11_d554e5de : PS1, Line 7: src/acpi: Modify ACPI revision Please use:
acpi: Increase ACPI revision from 6.0 to 6.4
https://review.coreboot.org/c/coreboot/+/80781/comment/6d286a33_3442dfbf : PS1, Line 9: Modify ACPI revision from 6.0 to 6.4
The ACPI PROCESSOR_OP has been deprecated in ACPI 6.0 and dropped in ACPI 6.4. […]
Does the coreboot code need to be adapted?
``` $ git grep PROCESSOR_OP src/acpi/acpigen.c: acpigen_emit_ext_op(PROCESSOR_OP); src/include/acpi/acpigen.h: PROCESSOR_OP = 0x83, src/vendorcode/intel/edk2/UDK2017/MdePkg/Include/IndustryStandard/AcpiAml.h:#define AML_EXT_PROCESSOR_OP 0x83 src/vendorcode/intel/edk2/edk2-stable202005/MdePkg/Include/IndustryStandard/AcpiAml.h:#define AML_EXT_PROCESSOR_OP 0x83 src/vendorcode/intel/edk2/edk2-stable202302/MdePkg/Include/IndustryStandard/AcpiAml.h:#define AML_EXT_PROCESSOR_OP 0x83 ```
https://review.coreboot.org/c/coreboot/+/80781/comment/60d74ef4_b53b4e16 : PS1, Line 12: Signed-off-by: liminyu li.minyu@h3c.com Ditto.