[coreboot-gerrit] [XS] Change in coreboot[main]: util/amdfwtool/amdfwread.c: Properly error out in relative_offset()

[Maximilian Brune (Code Review)]

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/87298?usp=email )

Change subject: util/amdfwtool/amdfwread.c: Properly error out in relative_offset()
......................................................................

util/amdfwtool/amdfwread.c: Properly error out in relative_offset()

The addresses and their modes should now all be correct and we can
therefore treat the case where `addr` and `mode` do not match as an
actual error.

Signed-off-by: Maximilian Brune 
Change-Id: Id12c29648c0437dd082b471689ec3649314dee1c
---
M util/amdfwtool/amdfwread.c
1 file changed, 1 insertion(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/87298/1

diff --git a/util/amdfwtool/amdfwread.c b/util/amdfwtool/amdfwread.c
index 4dd3b0f..f581c1b 100644
--- a/util/amdfwtool/amdfwread.c
+++ b/util/amdfwtool/amdfwread.c
@@ -30,10 +30,7 @@
    case AMD_ADDR_PHYSICAL:
    	if (addr < SPI_ROM_BASE || addr > (SPI_ROM_BASE + FILE_REL_MASK)) {
    		ERR("Invalid address(%lx) or mode(%lx)\n", addr, mode);
-			/* TODO: fix amdfwtool to program the right address/mode. In guybrush,
-			 * lots of addresses are marked as physical, but they are relative to
-			 * BIOS. Until that is fixed, just leave an error message. */
-			// exit(1);
+			exit(1);
    	}
    	return addr & FILE_REL_MASK;