Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35315 )
Change subject: Update vboot submodule to upstream master
......................................................................
Patch Set 2:
Patch Set 2:
We are facing a build error with this version of vboot
gcc: error: unrecognized command line option '-Wimplicit-fallthrough'
Is this version of vboot requires a newer GCC version?
What compiler are you using? We generally expect developers to use our coreboot-sdk toolchain (from util/crossgcc) for reproducible results.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35315
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7cefa3ad5b30c955d18e469494fec32f6f58a48
Gerrit-Change-Number: 35315
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Krzysztof M Sywula
krzysztof.m.sywula@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 27 Sep 2019 20:12:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment