Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42470 )
Change subject: drivers/intel/mipi_camera: Add support to handle CIO2 device
......................................................................
Patch Set 9: -Code-Review
(1 comment)
https://review.coreboot.org/c/coreboot/+/42470/9/src/drivers/intel/mipi_came...
File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/42470/9/src/drivers/intel/mipi_came...
PS9, Line 264: if (!config->remote_name) {
: if (cio2)
: config->remote_name = acpi_device_path(cio2);
: else
: config->remote_name = DEFAULT_REMOTE_NAME;
: }
I think a potential issue got introduced during the refactoring. […]
Good catch Matt.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I521740524bc1c4da3d8593f011a033542e4a872c
Gerrit-Change-Number: 42470
Gerrit-PatchSet: 9
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jun 2020 21:40:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt Delco
delco@chromium.org
Gerrit-MessageType: comment