Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7290
-gerrit
commit 410f054ad2c295a34becafc21f00acb0b52fa9d3 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Fri Oct 31 08:54:41 2014 +1100
Redundant addr '&' operator on func ptr's in struct initiator
Bring code inline to be consistent with the rest of coreboot.
See standard - c99std (n1256) 6.3.2.1p4 - to paraphrase, 'expressions that refer to functions get converted to pointers to those functions'
Change-Id: I63a7bed5efade37dd7076dbfc9c85d420cf6c92b Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/northbridge/via/cx700/lpc.c | 4 ++-- src/soc/intel/broadwell/systemagent.c | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/northbridge/via/cx700/lpc.c b/src/northbridge/via/cx700/lpc.c index da3e2ce..1e6d2ce 100644 --- a/src/northbridge/via/cx700/lpc.c +++ b/src/northbridge/via/cx700/lpc.c @@ -296,12 +296,12 @@ static struct device_operations cx700_lpc_ops = { .read_resources = cx700_read_resources, .set_resources = cx700_set_resources, .enable_resources = cx700_enable_resources, - .init = &cx700_lpc_init, + .init = cx700_lpc_init, .scan_bus = scan_static_bus, };
static const struct pci_driver lpc_driver __pci_driver = { - .ops = &cx700_lpc_ops, + .ops = &cx700_lpc_ops, .vendor = PCI_VENDOR_ID_VIA, .device = 0x8324, }; diff --git a/src/soc/intel/broadwell/systemagent.c b/src/soc/intel/broadwell/systemagent.c index 787a62b..2b3ce41 100644 --- a/src/soc/intel/broadwell/systemagent.c +++ b/src/soc/intel/broadwell/systemagent.c @@ -433,12 +433,12 @@ static void systemagent_enable(device_t dev) }
static struct device_operations systemagent_ops = { - .read_resources = &systemagent_read_resources, - .set_resources = &pci_dev_set_resources, - .enable_resources = &pci_dev_enable_resources, - .init = &systemagent_init, - .enable = &systemagent_enable, - .ops_pci = &broadwell_pci_ops, + .read_resources = systemagent_read_resources, + .set_resources = pci_dev_set_resources, + .enable_resources = pci_dev_enable_resources, + .init = systemagent_init, + .enable = systemagent_enable, + .ops_pci = broadwell_pci_ops, };
static const unsigned short systemagent_ids[] = {