[coreboot-gerrit] Change in coreboot[master]: soc/amd: move non-CAR linker scripts to common directory

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47828 )

Change subject: soc/amd: move non-CAR linker scripts to common directory
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47828/2/src/soc/amd/common/block/cp... 
File src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld:

https://review.coreboot.org/c/coreboot/+/47828/2/src/soc/amd/common/block/cp... 
PS2, Line 86: 	_ = ASSERT(CONFIG_BOOTBLOCK_ADDR == ((CONFIG_BOOTBLOCK_ADDR + 0xFFFF) & 0xFFFF0000), "Bootblock must be 16 bit aligned");
> Looking back at this, it does seem overly constrained. […]

Is it a flaw that .reset and the entire uncompressed bootblock appears at end of coreboot.rom for google/zork variants? The Taken execution path is the compressed bootblock embedded in amdfw.rom?

For the traditional x86 bootflow I am attempting to get rid of C_ENV_BOOTBLOCK_SIZE to pack coreboot.rom more efficiently and avoid cases where the static size has to be increased when e.g. bootblock console or other debugging is enabled.