Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42029 )
Change subject: smbios: Add option VPD_SMBIOS_VERSION that reads BIOS version from a VPD variable ......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42029/8/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/42029/8/src/Kconfig@763 PS8, Line 763: default "firmware_version"
"firmware_version" sounds better, "version" is too unspecific. […]
Done
https://review.coreboot.org/c/coreboot/+/42029/13/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/42029/13/src/arch/x86/smbios.c@452 PS13, Line 452: t->bios_version = smbios_add_string(t->eos, get_bios_version());
Just move this line further up so you can combine all the conditional stuff in a single #if block?
I moved it down instead because version_offset calculated at https://review.coreboot.org/c/coreboot/+/42029/14/src/arch/x86/smbios.c#447 can be affected.
https://review.coreboot.org/c/coreboot/+/42029/13/src/arch/x86/smbios.c@454 PS13, Line 454: /* SMBIOS offsets start at 1 rather than 0 */ : chromeos_get_chromeos_acpi()->vbt10 = (u32)t->eos + (version_offset - 1);
maybe someone can double confirm, but I think this can be moved to before t->bios_version line, beca […]
Done