[coreboot-gerrit] Change in coreboot[master]: sc7180: GPIO: Add I2S configuration for sc7180

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38593 )

Change subject: sc7180: GPIO: Add I2S configuration for sc7180
......................................................................

Patch Set 22: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/38593/16/src/mainboard/google/trogd... 
File src/mainboard/google/trogdor/mainboard.c:

https://review.coreboot.org/c/coreboot/+/38593/16/src/mainboard/google/trogd... 
PS16, Line 37: GPIO_PULL_UP
> done

I know it's functionally the same, but it is potentially wasting power by leakage through the pull resistor. If it works without the pull, please disable it. (Also, more importantly, I noticed that the same pull seems to be configured in the kernel DTS, so please disable it there as well.)