Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40337 )
Change subject: soc/intel/{apl, cnl, skl}: Add sanity check of SA_PCIEX_LENGTH_MIB
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40337/1/src/soc/intel/skylake/syste...
File src/soc/intel/skylake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/40337/1/src/soc/intel/skylake/syste...
PS1, Line 17: #if (CONFIG_SA_PCIEX_LENGTH_MIB > 0x100) /* Max length is 256MB */
: #error "Invalid SA_PCIEX_LENGTH_MIB selection!"
: #endif
The code from src/soc/intel is used not only for SoC. What about the Xeon E3-1230 v6 lga-1151 processor? Is this limitation also necessary for all Sky/Kaby Lake CPUs?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40337
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0dd67868df373c6ab5c724a21371bcc206968036
Gerrit-Change-Number: 40337
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Comment-Date: Mon, 13 Apr 2020 09:06:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment