build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39821 )
Change subject: nb/i945: Split ramint into desktop and mobile version ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/39821/2/src/northbridge/intel/i945/... File src/northbridge/intel/i945/raminit_i945gc.c:
https://review.coreboot.org/c/coreboot/+/39821/2/src/northbridge/intel/i945/... PS2, Line 436: die("Only DDR-II RAM with burst length 8 is supported by this chipset.\n"); line over 96 characters
https://review.coreboot.org/c/coreboot/+/39821/2/src/northbridge/intel/i945/... PS2, Line 904: if ((slew_group_lookup(dual_channel, idx * 8 + 2) != nc) && (sysinfo->package == SYSINFO_PACKAGE_STACKED)) line over 96 characters
https://review.coreboot.org/c/coreboot/+/39821/2/src/northbridge/intel/i945/... PS2, Line 1363: case 533: break; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/39821/2/src/northbridge/intel/i945/... PS2, Line 1364: case 667: tRD_min += 1; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/39821/2/src/northbridge/intel/i945/... PS2, Line 1366: case 800: tRD_min += 2; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/39821/2/src/northbridge/intel/i945/... PS2, Line 1368: case 1066: tRD_min += 3; trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/39821/2/src/northbridge/intel/i945/... PS2, Line 2391: printk(BIOS_DEBUG, "bankaddr from bank size of rank %d\n", nonzero); line over 96 characters