Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32076 )
Change subject: mb/protectli/vault: Add FW2B and FW4B boards support
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/32076/14//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/32076/14//COMMIT_MSG@8
PS14, Line 8:
Despite the added documentation, I’d still mention the *Braswell* in the commit message, and explain that both boards are similar.
https://review.coreboot.org/c/coreboot/+/32076/14/MAINTAINERS
File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/32076/14/MAINTAINERS@330
PS14, Line 330: F: src/mainboard/protectli/
I’d prefer a separate commit for this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32076
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I553fd3a89299314a855f055014ca7645100e12e7
Gerrit-Change-Number: 32076
Gerrit-PatchSet: 14
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Mar 2020 12:25:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment