Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36449 )
Change subject: mainboard/google: Allow Hatch variants to read SPD data over SMBus
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36449/3/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/romstage_spd_smbus.c:
https://review.coreboot.org/c/coreboot/+/36449/3/src/mainboard/google/hatch/...
PS3, Line 26: struct spd_info spd[NUM_DIMM_SLOT] = {
: {
: .read_type = READ_SMBUS,
: .spd_spec = {.spd_smbus_address = 0xa0},
: },
: {
: .read_type = NOT_EXISTING,
: },
: {
: .read_type = READ_SMBUS,
: .spd_spec = {.spd_smbus_address = 0xa4},
: },
: {
: .read_type = NOT_EXISTING,
: },
: };
: memcpy(memcfg.spd, spd, sizeof(memcfg.spd));
Could this be directly assigned to memcfg. […]
memcpy() removed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36449
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3516a46b91840a9f6d1f4cffb2553d939d79cda2
Gerrit-Change-Number: 36449
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 06 Nov 2019 00:18:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment