Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32800 )
Change subject: mt8183: add efuse calibration in auxadc ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/#/c/32800/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32800/7//COMMIT_MSG@2 PS7, Line 2: jg_poxu Please use your full name.
$ git config --global user.name "…" $ git commit --amend -s --author="… jg_poxu@mediatek.com"
https://review.coreboot.org/#/c/32800/7//COMMIT_MSG@9 PS7, Line 9: due to not get efuse calibration, auxadc get value has deviated Please start sentences with capital letter and add a dot at the end.
https://review.coreboot.org/#/c/32800/7//COMMIT_MSG@10 PS7, Line 10: add adding
https://review.coreboot.org/#/c/32800/7/src/soc/mediatek/mt8183/auxadc.c File src/soc/mediatek/mt8183/auxadc.c:
https://review.coreboot.org/#/c/32800/7/src/soc/mediatek/mt8183/auxadc.c@26 PS7, Line 26: : #define ADC_GE_A_SHIFT 10 : #define ADC_GE_A_MASK (0x3ff << ADC_GE_A_SHIFT) : #define ADC_OE_A_SHIFT 0 : #define ADC_OE_A_MASK (0x3ff << ADC_OE_A_SHIFT) : #define ADC_CALI_EN_A_SHIFT 20 : #define ADC_CALI_EN_A_MASK (0x1 << ADC_CALI_EN_A_SHIFT) : #define AUXADC_CALI_INIT -0xffff Please use tabs or spaces consistently for alignment.
https://review.coreboot.org/#/c/32800/7/src/soc/mediatek/mt8183/auxadc.c@35 PS7, Line 35: static int cali_oe = AUXADC_CALI_INIT; What does *oe* and *ge* stand for? Add a comment?