Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47417 )
Change subject: mb/google/hatch: Configure IRQs as level triggered for HID over I2C ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47417/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/47417/2/src/mainboard/google/hatch/... PS2, Line 182: PAD_CFG_GPI_APIC(GPP_D16, NONE, PLTRST, LEVEL, NONE),
shouldn't this be inverted then? PAD_CFG_GPI_APIC(GPP_D16, NONE, PLTRST, LEVEL, INVERT) or PAD_CFG_G […]
No, the signal is passed as is at the pad level and the APIC redirection entry has the right trigger level low. Example: https://review.coreboot.org/c/coreboot/+/47417/2/src/mainboard/google/hatch/...