Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43303 )
Change subject: mb/amd,google/mandolin,zork: Set EFS SPI platform config
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43303/16/src/mainboard/amd/mandolin...
File src/mainboard/amd/mandolin/Kconfig:
https://review.coreboot.org/c/coreboot/+/43303/16/src/mainboard/amd/mandolin...
PS16, Line 110: default 6
: default 0 if EM100
These are reversed for all 4 with an EM100. […]
+1 to default for EM100 to be placed first. Also, I think this can live in the soc/common/block/spi/Kconfig or at least at the Picasso SoC level.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43303
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I765dada14700f4800263d2d3844af07fad0e5b71
Gerrit-Change-Number: 43303
Gerrit-PatchSet: 16
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 28 Jul 2020 22:03:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment