[coreboot-gerrit] Change in ...coreboot[master]: southbridge/intel/common/smbus.c: Add support for I2C block write

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30800 )

Change subject: southbridge/intel/common/smbus.c: Add support for I2C block write
......................................................................

Patch Set 14:

(1 comment)
> Patch Set 13:
>
> (2 comments)

Any new comment?

https://review.coreboot.org/#/c/30800/13/src/southbridge/intel/common/smbus.... 
File src/southbridge/intel/common/smbus.c:

https://review.coreboot.org/#/c/30800/13/src/southbridge/intel/common/smbus.... 
PS13, Line 415:
> all other functions in this file expect "smbus_base" as argument. […]

How to proceed with this patch set and handle your comment?
The I2C_EN is required to run int I2C mode.
An alternative can be moving i2c_block_write() to SoC Braswell and have this support for Braswell only.