Attention is currently required from: Nico Huber, Tim Wawrzynczak, Subrata Banik, Andrey Petrov, Patrick Rudolph, Nathaniel L Desimone.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49899 )
Change subject: soc/intel/*: Update microcode as specified for MP-init
......................................................................
Patch Set 13:
(1 comment)
File src/soc/intel/alderlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/49899/comment/4edc4491_3b91d460
PS13, Line 70: PRMRR
For ADL, there is a new MCHECK flow in the FSP, which apparently requires a microcode load immediate […]
for CML: it doesn't mention it explicitly, but I reads as SMRR is updated with MTRR, PRMRR and DCU mode in Phase 3. SMRR is only written in SMM which would match the comment.
For Icelake/Tigerlake it says:
Must reload after memory initialization and PRMRR are configured.
PRMRR isn't currently configured on those platforms, so a second microcode update isn't required at all?
Should I remove the second microcode update from all platforms using CpuMpPpi? That is Icelake+ ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49899
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf2b009ac9dd7cd462abe0f787f27b09feb6ec5b
Gerrit-Change-Number: 49899
Gerrit-PatchSet: 13
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Comment-Date: Wed, 10 Feb 2021 18:49:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment