[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/cmd/block: Implement an API to get firmware partition details

[Sridhar Siricilla (Code Review)]

Attention is currently required from: Subrata Banik, Haribalaraman Ramasubramanian, Dinesh Gehlot, Rizwan Qureshi, Reka Norman, Kapil Porwal.

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 )

Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details
......................................................................

Patch Set 26: Code-Review+2

(2 comments)

File src/soc/intel/common/block/cse/cse.c:

https://review.coreboot.org/c/coreboot/+/74005/comment/ddc18286_6d95edda 
PS26, Line 1224: partitionId
nit:camelcase needs to be avoided

https://review.coreboot.org/c/coreboot/+/74005/comment/4da71c32_c3c0954d 
PS26, Line 1240: 	if (cse_is_hfs1_com_soft_temp_disable()) {
               : 		printk(BIOS_ERR, "HECI: Prerequisites not met for fw partition request\n");
               : 		return false;
               : 	}
               : 
               : 	if (!cse_is_hfs1_cws_normal() || !cse_is_hfs1_com_normal()) {
               : 		printk(BIOS_ERR, "HECI: Prerequisites not met for fw partition request\n");
               : 		return false;
               : 	}
Can you combine these 2 conditions? May be you can do through separate CL.