Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55022 )
Change subject: mb/google/guybrush: Unassign I2C1 and set them to input/no-pull ......................................................................
mb/google/guybrush: Unassign I2C1 and set them to input/no-pull
The DisplayPort redriver connected to I2C1 will be configured by the EC. There is a communication problem if coreboot configures and/or uses these pins, so just set them to inputs.
BUG=b:187856682 TEST=Initialize the DisplayPort redriver from the EC
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: I244b398c695683fa4e217d83aa0498bcd8f0fbbe --- M src/mainboard/google/guybrush/variants/baseboard/gpio.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/55022/1
diff --git a/src/mainboard/google/guybrush/variants/baseboard/gpio.c b/src/mainboard/google/guybrush/variants/baseboard/gpio.c index c89ded2..bd0ac50 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/gpio.c +++ b/src/mainboard/google/guybrush/variants/baseboard/gpio.c @@ -159,10 +159,10 @@ PAD_NF(GPIO_145, I2C0_SCL, PULL_NONE), /* I2C0_SDA */ PAD_NF(GPIO_146, I2C0_SDA, PULL_NONE), - /* I2C1_SCL */ - PAD_NF(GPIO_147, I2C1_SCL, PULL_NONE), - /* I2C1_SDA */ - PAD_NF(GPIO_148, I2C1_SDA, PULL_NONE), + /* I2C1_SCL - Unused */ + PAD_GPI(GPIO_147, PULL_NONE), + /* I2C1_SDA - Unused */ + PAD_GPI(GPIO_148, PULL_NONE), };
/* Early GPIO configuration */