[coreboot-gerrit] [XS] Change in coreboot[main]: mb/google/fatcat: Enable PCH Energy Report

[Jamie Ryu (Code Review)]

Attention is currently required from: Bora Guvendik, Hima B Chilmakuru, Jamie Ryu, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Vikrant L Jadeja, Wonkyu Kim.

Jamie Ryu has posted comments on this change by Jamie Ryu. ( https://review.coreboot.org/c/coreboot/+/85615?usp=email )

Change subject: mb/google/fatcat: Enable PCH Energy Report
......................................................................

Patch Set 3:

(2 comments)

File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/85615/comment/6b62b599_6abde8b8?usp... :
PS1, Line 38: 
            : 	# TODO: Safe Setting. Needs to be removed later
            : 	# Disable C1 C-state auto-demotion
            : 	register "disable_c1_state_auto_demotion" = "true"
> Let me check this with PTL and update.

I am keeping C state auto demotion disabled for PTL in patchset#3, similar to previous generations.

https://review.coreboot.org/c/coreboot/+/85615/comment/c40d0fac_91863c1a?usp... :
PS1, Line 42: 	# Enable Energy Reporting
            : 	register "pch_pm_energy_report_enable" = "true"
> can you please submit this CL for review

The patch is updated for review. Thank you.