Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian, Mark Hasemeyer.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74281 )
Change subject: mb/google/myst: Store XHCI PCI resources
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74281/comment/798ecbda_4d5d0752
PS5, Line 14: TEST=builds
How do we track going back and verifying these types of CLs are working correctly?
For example, when this was added for skyrim, the testing involved verifying the wake events appear in elog:
https://review.coreboot.org/c/coreboot/+/68325
```
TEST=Ran on skyrim proto, verified that wake events show in elog
```
We should make sure this type of functionality is working as part of the bringup process, rather than finding out later (when we need it) it's been broken.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74281
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I608d51f438681ac529323c23cc707845a3d609d1
Gerrit-Change-Number: 74281
Gerrit-PatchSet: 5
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Mon, 10 Apr 2023 16:13:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment