Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31448 )
Change subject: src/device/pci: Add support for discrete VGA initialization and OpROM loading ......................................................................
Patch Set 20:
(2 comments)
https://review.coreboot.org/c/coreboot/+/31448/12//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/31448/12//COMMIT_MSG@15 PS12, Line 15: Later will try to make a common VFCT table for both adapters.
I'd focus on that. This patch just seems like a hack...
That's probably for another, future patch...
https://review.coreboot.org/c/coreboot/+/31448/1/src/device/pci_rom.c File src/device/pci_rom.c:
https://review.coreboot.org/c/coreboot/+/31448/1/src/device/pci_rom.c@231 PS1, Line 231: if (!IS_ENABLED(CONFIG_MULTIPLE_VGA_ADAPTERS)) { : /* Copy Integrated VGA VBIOS from CBFS to ACPI VFCT. */ : printk(BIOS_DEBUG, " Copying %sVBIOS image from %p\n", : rom == (struct rom_header *) : (uintptr_t)PCI_VGA_RAM_IMAGE_START ? : "initialized " : "", : rom); : } else { : /* Copy Discrete VGA VBIOS from CBFS to ACPI VFCT. */ : printk(BIOS_DEBUG, " Copying %sVBIOS image from %p\n", : rom == (struct rom_header *) : (uintptr_t)PCI_RAM_IMAGE_START ? : "initialized " : "", : rom); : /* TODO: do this also for Integrated VGA VBIOS. */ : }
there's a small but important difference: PCI_VGA_RAM_IMAGE_START and PCI_RAM_IMAGE_START addresses.
Resolved.