Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81379?usp=email )
Change subject: Kconfig: Make GBD_STUB and long mode mutually exclusive ......................................................................
Kconfig: Make GBD_STUB and long mode mutually exclusive
The GDB setup does not compile and was never tested with long mode.
Change-Id: Icaf7d0763829d5badf73d38bb8fc3d36cfe18964 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/Kconfig M src/arch/x86/c_start.S 2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/81379/1
diff --git a/src/Kconfig b/src/Kconfig index 3a9a4e8..78ff0a8 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1015,7 +1015,8 @@ config GDB_STUB bool "GDB debugging support" default n - depends on DRIVERS_UART +# FIXME Not correctly implemented in long mode + depends on DRIVERS_UART && !USE_X86_64_SUPPORT help If enabled, you will be able to set breakpoints for gdb debugging. See src/arch/x86/c_start.S for details. diff --git a/src/arch/x86/c_start.S b/src/arch/x86/c_start.S index 6bea8db..266d8f0 100644 --- a/src/arch/x86/c_start.S +++ b/src/arch/x86/c_start.S @@ -129,6 +129,7 @@ gdb_stub_breakpoint: #if ENV_X86_64 pop %rax /* Return address */ + /* FIXME: instructions below are not valid in long mode */ pushfl push %cs push %rax /* Return address */