Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42521 )
Change subject: mb/pcengines/apu2: Switch to proper GPIO API
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42521/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42521/2//COMMIT_MSG@13
PS2, Line 13: takes advantage of this property.
Please let me know when you have the patch stack in order the way you like. […]
Ack
https://review.coreboot.org/c/coreboot/+/42521/7/src/mainboard/pcengines/apu...
File src/mainboard/pcengines/apu2/romstage.c:
https://review.coreboot.org/c/coreboot/+/42521/7/src/mainboard/pcengines/apu...
PS7, Line 36: gpio_output(gpio, setting & GPIO_OUTPUT_VALUE);
To avoid glitches ? […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42521
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I348ba43a76287be5b24012ae3dfc28ed783da9c7
Gerrit-Change-Number: 42521
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 26 Jun 2020 08:54:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment