Attention is currently required from: Hung-Te Lin, Jianjun Wang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56792 )
Change subject: soc/mediatek/mt8195: Add driver to configure PCIe
......................................................................
Patch Set 6:
(1 comment)
File src/soc/mediatek/mt8195/pcie.c:
https://review.coreboot.org/c/coreboot/+/56792/comment/8946358e_be183dc1
PS6, Line 16: {
: .cpu_addr = 0x20000000,
: .pci_addr = 0x20000000,
: .size = 0x1000000,
: .type = IORESOURCE_IO,
: },
: {
: .cpu_addr = 0x21000000,
: .pci_addr = 0x21000000,
: .size = 0x3000000,
: .type = IORESOURCE_MEM,
: },
Sorry, last wish from my side. Where are these values from? Maybe add a comment?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56792
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6799c53b03a33be91157ea088d829beb4272976
Gerrit-Change-Number: 56792
Gerrit-PatchSet: 6
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Dec 2021 09:37:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment