Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44804 )
Change subject: mb/google/vilboz: update telemetry settings
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44804/2/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44804/2/src/mainboard/google/zork/v...
PS2, Line 24: telemetry_vddcr_soc_offset
This seems to be a uint32_t field(https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/amd/picasso/chip....). Is the negative value actually expected? Does the field type needs to be changed?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44804
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4cf5b8f090befd6a3c4990f44f2f200bc66aa1f4
Gerrit-Change-Number: 44804
Gerrit-PatchSet: 2
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 07 Sep 2020 22:54:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment