Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36381 )
Change subject: [WIP] mb/asrock/h110m: use SuperIO acpigen
......................................................................
Patch Set 2: Code-Review+1
The code generating the errors was written by Intel TM without knownledge how hardware works. If the LPC decode ranges were correct before using the superio ssdtgen you can ignore the warnings.
ouch, do they try to use programmable lpc io decode ranges for components using the fixed function lpd io range decodes?! if so, this should be fixed...
the patch itself looks good to me
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36381
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57b67d10968e5e035536bcb0d8329ce09d50194b
Gerrit-Change-Number: 36381
Gerrit-PatchSet: 2
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Oct 2019 15:25:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment