Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Paul Menzel, Subrata Banik, Sathya Prakash M R, Tim Wawrzynczak.
Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51510 )
Change subject: mb/google/brya: Enable display and DSP audio UPD
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/51510/comment/e2e64cdb_00e5398d
PS4, Line 63: pLinkTmode" = "HDA_TMODE_8T"
: register "PchHdaIDispLinkFre
if not now, later stage.. please help do this:
For iDisp link mode and link frequency UPD config params -
Do not program in devicetree, instead leave it to FSP?
for e.g.
In TGL, we initially had that setting from DT and later changed. Please see this.
https://review.coreboot.org/c/coreboot/+/40263
Also, for ADL_M RVP, it has been tried and working:
https://review.coreboot.org/c/coreboot/+/51353
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3dab02bedb6df995b1efd27332d3aa26985e188e
Gerrit-Change-Number: 51510
Gerrit-PatchSet: 4
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-CC: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Sathya Prakash M R
sathya.prakash.m.r@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Mon, 22 Mar 2021 18:13:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment