Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39318 )
Change subject: chromeos: stop sharing write protect GPIO with depthcharge
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39318/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39318/1//COMMIT_MSG@17
PS1, Line 17: Change-Id: I2fcb7f82aa063fd72928171af5cbef0356ba620c
Done
Yes, that is a good idea. Payload requirements should be documented.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39318
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fcb7f82aa063fd72928171af5cbef0356ba620c
Gerrit-Change-Number: 39318
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Mar 2020 12:19:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joel Kitching
kitching@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment