Hello Kyösti Mälkki, Marshall Dawson, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37178
to look at the new patch set (#10).
Change subject: soc/amd/common/block/acpimmio: fix ACPIMMIO decode enable function ......................................................................
soc/amd/common/block/acpimmio: fix ACPIMMIO decode enable function
According to BKDGs for families 15h 60-6fh or newer and families 16h the ACPI MMIO decode enable bit is the second LSB, not the first LSB.
Additionally create another enable function for older families where the register and bit is different.
It does not seem to impact any current board, but may be crucial for incoming C bootblock implementations when this bit will need to be set very early. Most likely this bit is set by AGESA right now.
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Iaa31abc3dbdf77d8513fa83c7415b9a1b7fd266f --- M src/soc/amd/common/block/acpimmio/mmio_util.c M src/soc/amd/common/block/include/amdblocks/acpimmio.h M src/soc/amd/common/block/include/amdblocks/acpimmio_map.h M src/soc/amd/picasso/southbridge.c M src/soc/amd/stoneyridge/southbridge.c 5 files changed, 33 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/37178/10