Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure
......................................................................
Patch Set 2: Code-Review-1
I don't see the benefit here. Why do we group the boards by socket or southbridge? And not keep the old style x11ssh as baseboard with it's variants t, TF etc.?
Do we do this style of grouping somewhere else? I really don't like this type of grouping because it makes it more unclear. So when I have a x11sch-f , I first need to check socket or sb and then I can find it in the tree?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35426
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29
Gerrit-Change-Number: 35426
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 16 Sep 2019 16:10:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment