Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34905 )
Change subject: mb/supermicro/x10slm-f: Fix IPMI KCS
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1...
File src/mainboard/supermicro/x10slm-f/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34905/8/src/mainboard/supermicro/x1...
PS8, Line 5: ## Copyright (C) 2019 Hosting.de GmbH c.pomaska@hosting.de
Usually we argue that copyright only applies to code and not to "config" files that have a predefine […]
Well, it wouldn't be any problem if there was a Copyright on the original work. Then this Copyright would be copied, too, and another Copyright added. What I actually do not know is, if it is valid to add a Copyright header when there was none before, even when the code/config generally is GPL. TL;DR I really have no clue but I would remove the whole GPL header for the reason Patrick mentioned. AFAIK config can't be licensed at all (I may be wrong here...)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34905
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f89c2ddcc00327e01d0a83fc13cfa862e6abd70
Gerrit-Change-Number: 34905
Gerrit-PatchSet: 12
Gerrit-Owner: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christoph Pomaska
github@aufmachen.jetzt
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 12 Oct 2019 16:24:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Christoph Pomaska
github@aufmachen.jetzt
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Gerrit-MessageType: comment