14 Oct
2020
14 Oct
'20
5:32 a.m.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46234 )
Change subject: mb/google/volteer: Drop GPIO_MEM_CONFIG macros ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46234/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/46234/4/src/mainboard/google/voltee... PS4, Line 72: GPP_C12,
It would be good to have a comment here which will make it easier to associate which GPIO correspond […]
yeah..added comment
--
To view, visit https://review.coreboot.org/c/coreboot/+/46234
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c1ebfb39b2a56ca94a92941e8beed1acc28e655
Gerrit-Change-Number: 46234
Gerrit-PatchSet: 5
Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org
Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Oct 2020 05:32:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment