Tommie Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43442 )
Change subject: mb/google/volteer: Add new variant Lingcod
......................................................................
Patch Set 9:
(1 comment)
Patch Set 9:
(14 comments)
Do you have the lingcod gpio vs volteer gpio table? I would like to double check your GPIO setting.
Yes, I share S560&C560_PCH_GPIO_Table-20200629_Reviewed.xlsx with you on Google Drive.
https://review.coreboot.org/c/coreboot/+/43442/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43442/6//COMMIT_MSG@14
PS6, Line 14: TEST=emerge-volteer coreboot
The most important question is: does it boot? 😄
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43442
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f79431d3948788ce27ae14b469ffc229ebf8b6a
Gerrit-Change-Number: 43442
Gerrit-PatchSet: 9
Gerrit-Owner: Tommie Lin
tong.lin@bitland.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Tommie Lin
tong.lin@bitland.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 Jul 2020 01:55:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment