Attention is currently required from: Patrick Georgi.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59229 )
Change subject: Documentation: Add warning about "private" changes on Gerrit
......................................................................
Patch Set 3:
(1 comment)
File Documentation/getting_started/gerrit_guidelines.md:
https://review.coreboot.org/c/coreboot/+/59229/comment/688b78f1_4e998aae
PS3, Line 197: Note that private
Nit: Note, private …
`Note that ...` is also correct, and it's what I'd use here. The comma in `Note, ...` kind of "breaks the reading flow" of the sentence.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59229
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c8c6cccfd023bc1d839dc5d9544204c88f89c7e
Gerrit-Change-Number: 59229
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Comment-Date: Thu, 02 Dec 2021 09:12:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment