[coreboot-gerrit] Change in ...coreboot[master]: mainboard/intel: Update mainboard UART Kconfig

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30913 )

Change subject: mainboard/intel: Update mainboard UART Kconfig
......................................................................

Patch Set 2:

(4 comments)

https://review.coreboot.org/#/c/30913/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30913/2//COMMIT_MSG@9 
PS2, Line 9: CL:29573
> should be CB:... as this redirects to the chromium gerrit from here.

Done

https://review.coreboot.org/#/c/30913/2/src/mainboard/intel/coffeelake_rvp/K... 
File src/mainboard/intel/coffeelake_rvp/Kconfig:

https://review.coreboot.org/#/c/30913/2/src/mainboard/intel/coffeelake_rvp/K... 
PS2, Line 21: INTEL_LPSS_UART_FOR_CONSOLE
> I mean removing condition in line #10 is enough.

Done

https://review.coreboot.org/#/c/30913/2/src/mainboard/intel/coffeelake_rvp/K... 
PS2, Line 92: config UART_FOR_CONSOLE
            : 	int
            : 	default 2
> Same changes for #52 ~ 55. […]

Done

https://review.coreboot.org/#/c/30913/2/src/mainboard/intel/kblrvp/Kconfig 
File src/mainboard/intel/kblrvp/Kconfig:

https://review.coreboot.org/#/c/30913/2/src/mainboard/intel/kblrvp/Kconfig@1 
PS2, Line 1: BOARD_INTEL_KBLRVP3 || BOARD_INTEL_KBLRVP7 || BOARD_INTEL_KBLRVP8
> RVP11 uses PCH UART2 (UART_FOR_CONSOLE=2) for debug purpose. […]

RVP 8 is using UART 2 that i'm aware