Attention is currently required from: Jason Glenesk, Martin Roth.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50462 )
Change subject: soc/amd: factor out common SMM relocation code
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/50462/comment/f6d67452_ca9920a5
PS4, Line 32: bool
Thinking about my comment in CB:50455, we could add a depends on SMM_TSEG && HAVE_SMI_HANDLER here, […]
hm, not sure. i'd say that smm is in tseg can just be assumed; not sure if smm would even fit into legacy aseg. not planning to do anything about this
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50462
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45224131dfd52247018c5ca19cb37c44062b03eb
Gerrit-Change-Number: 50462
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Wed, 10 Feb 2021 21:29:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment