Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38370 )
Change subject: rtc/post.c: Fix compilation issue for post.c
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
@Maulik, i guess your problem statement is you are trying to use postcodes inside SMM mode and you saw compiler issue. Is that right ?
Although i don't know if we have any restriction of postcode usage in SMM mode but somewhere its worth to capture this and as Kyosti has mentioned if you don't want SMM use postcode then guard with preprocessor macros
Yes Subrata...I see compilation issues
Yes, I think I can update the patch to capture this information and restrict the usage of cmos_post_code inside SMM
cool
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38370
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iffdcccaad48e7ad96e068d07046630fbe4297e65
Gerrit-Change-Number: 38370
Gerrit-PatchSet: 1
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 12 Jan 2020 12:43:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment