CK HU has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44852 )
Change subject: soc/mediatek/mt8192: Add SPI flash controller dual read function
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44852/1/src/soc/mediatek/mt8192/inc...
File src/soc/mediatek/mt8192/include/soc/flash_controller.h:
https://review.coreboot.org/c/coreboot/+/44852/1/src/soc/mediatek/mt8192/inc...
PS1, Line 10: #define SFLASH_READ_DUAL_EN 0x1
: #define SFLASH_1_1_2_READ 0x3B
move these into enum
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44852
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iabd3668fc4bc42137b7743144fc1cced4fe72737
Gerrit-Change-Number: 44852
Gerrit-PatchSet: 2
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 04 Sep 2020 05:31:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment