[coreboot-gerrit] Change in ...coreboot[master]: src/soc/intel/cannonlake: Update FSP-M upd config for cml

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32767 )

Change subject: src/soc/intel/cannonlake: Update FSP-M upd config for cml
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/32767/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32767/2//COMMIT_MSG@7 
PS2, Line 7: Update FSP-M upd config for cml
> I am guessing this is dependent on a particular version of FSP?

Yes , This is for 1155 release.

https://review.coreboot.org/#/c/32767/2/src/soc/intel/cannonlake/romstage/fs... 
File src/soc/intel/cannonlake/romstage/fsp_params.c:

https://review.coreboot.org/#/c/32767/2/src/soc/intel/cannonlake/romstage/fs... 
PS2, Line 54: 	m_cfg->SerialIoUartDebugControllerNumber = CONFIG_UART_FOR_CONSOLE;
> src/soc/intel/cannonlake/romstage/fsp_params. […]

there is a dependency to headers in vendorcode.