Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42899 )
Change subject: Sc7180: Add support for sn65dsi86 bridge ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42899/12/src/drivers/ti/sn65dsi86br... File src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c:
https://review.coreboot.org/c/coreboot/+/42899/12/src/drivers/ti/sn65dsi86br... PS12, Line 473: return data; As discussed on https://issuetracker.google.com/issues/161373813, this return value also needs to be masked. Should just do something like
uint8_t lane_count;
sn65dsi86_bridge_dpcd_request(bus, chip, DP_MAX_LANE_COUNT, 1, DPCD_READ, &data); late_count &= DP_LANE_COUNT_MASK; i2c_write_field(bus, chip, SN_SSC_CONFIG_REG, MIN(lane_count, 3), 3, 4);
return lane_count;