[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Invoke pmc and hard reset only if CSE fails to ...

[Pratikkumar V Prajapati (Code Review)]

Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/22549 )

Change subject: soc/intel/cannonlake: Invoke pmc and hard reset only if CSE fails to reset
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/22549/1/src/soc/intel/cannonlake/reset.c
File src/soc/intel/cannonlake/reset.c:

https://review.coreboot.org/#/c/22549/1/src/soc/intel/cannonlake/reset.c@83
PS1, Line 83: if(!send_heci_reset_message())
            : 		return;
> We dont want to return from here if heci reset fails. we would try pmc and

Aah.. i see what you mean, but even if heci reset works then also there is no point to return.