4 Mar
2019
4 Mar
'19
2:57 p.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31671 )
Change subject: nb/intel/i945: Remove redundant use of ACPI offset operator ......................................................................
Patch Set 3: Code-Review+2
It was kinda useful as self-validating documentation (ie. it reset the pointer forward if necessary, failing when going backward and generally told you where you are). Given that iasl considers this undesirable, we'll have to follow.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31671
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1f2a2ace335af7984209c9e286b9f85e5342a7e
Gerrit-Change-Number: 31671
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 Mar 2019 13:57:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment