Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28101 )
Change subject: Makefile: Write .xcompile to $(obj) ......................................................................
Patch Set 6:
(4 comments)
Patch Set 6:
(6 comments)
.xcompile is also in the .gitignore file and could be removed from there.
I'm going to split this CL so the .xcompile is generated when calling abuild instead of failing because make was unable to locate it.
https://review.coreboot.org/c/coreboot/+/28101/6/Makefile File Makefile:
https://review.coreboot.org/c/coreboot/+/28101/6/Makefile@467 PS6, Line 467: .xcompile
Remove this one?
I think we should leave this here so any stale .xcompile objects get cleaned up.
https://review.coreboot.org/c/coreboot/+/28101/6/src/soc/nvidia/tegra124/lp0... File src/soc/nvidia/tegra124/lp0/Makefile:
https://review.coreboot.org/c/coreboot/+/28101/6/src/soc/nvidia/tegra124/lp0... PS6, Line 16: xcompile
Maybe instead of looking for it, just regenerate it here and use it from here? That way we don't ha […]
since this file doesn't respect the $(obj) variable I was hesitant to write anything into the src directory. I think this file needs to get converted so it acts like all the other ones.
https://review.coreboot.org/c/coreboot/+/28101/6/util/abuild/abuild File util/abuild/abuild:
https://review.coreboot.org/c/coreboot/+/28101/6/util/abuild/abuild@471 PS6, Line 471: include $(xcompile)
Doesn't this variable need to be defined in abuild? What if abuild is just run from the command lin […]
It's defined by the main Makefile which I now include. The main Makefile is responsible for creating the .xcompile file.
https://review.coreboot.org/c/coreboot/+/28101/6/util/abuild/abuild@476 PS6, Line 476: .DEFAULT_GOAL := missing_arches
Should this go in the other abuild commit?
It doesn't need to. previously missing_arches was the first rule, now that I include the main Makefile it is required since mising_arches is not the first rule. So it could go in either or.