[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8183: Add DSI driver

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31591 )

Change subject: soc/mediatek/mt8183: Add DSI driver
......................................................................

Patch Set 33:

(2 comments)

https://review.coreboot.org/c/coreboot/+/31591/33/src/soc/mediatek/mt8183/in... 
File src/soc/mediatek/mt8183/include/soc/dsi.h:

https://review.coreboot.org/c/coreboot/+/31591/33/src/soc/mediatek/mt8183/in... 
PS33, Line 111: 	u32 len;
Note the bitfield notation I had in my comment... the goal was to fit it in 8 bytes (and this would still make 16). If you don't like bitfields, you can also make them u8 each and only have 6 bytes of data, which should still be enough for the panels you have right now. (Technically, if they're all u8 it doesn't have to be divisible by 8 either... but it looks nicer.)

https://review.coreboot.org/c/coreboot/+/31591/33/src/soc/mediatek/mt8183/in... 
PS33, Line 482: extern
We don't use explicit extern qualifiers for function prototypes.