Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47171 )
Change subject: soc/intel/xeon_sp/skx: Reorder soc_util.c
......................................................................
Patch Set 2:
Patch Set 2:
(1 comment)
With BUILD_TIMELESS=1 the binaries are not identical
The order of the functions changed, so the binary will be different. I will note that I removed the #if ENV_RAMSTAGE, since it isn't needed as those functions moved to util.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47171
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab343e903e2478709fe91739c9ca77f587286df7
Gerrit-Change-Number: 47171
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 06 Nov 2020 17:37:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment